asmjs: enable MathBuiltinsCall test for OSX #4653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obastemur
force-pushed
the
enable_math_Builtins_osx
branch
from
fbd44cc
to
d9386a7
Compare
obastemur
force-pushed
the
enable_math_Builtins_osx
branch
from
d9386a7
to
7733541
Compare
boingoing
approved these changes
Feb 8, 2018
There was a problem hiding this comment.
Looks fine but I almost think it would be better to have MathBuiltinsCall.macos.baseline and override in rlexe.xml to choose that baseline when running on OSX. If only because if some other constant changes in the future it would be easier to update that baseline.
Your call on doing that, though.
|
So far the xplt approach was doing stuff internally based on ch environment values. The approach you mentioned also nice indeed. I just feel like, whoever opens that js file will see the exceptional cases without being bothered with baselines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4537