Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecates emitPackage #2302

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

astahmer
Copy link
Collaborator

@astahmer astahmer commented Mar 3, 2024

📝 Description

Deprecates emitPackage, it will be removed in the next major version.

Why?

It's known for causing several issues:

  • bundlers sometimes eagerly cache the node_modules, leading to panda codegen updates to the styled-system not
    visible in the browser
  • auto-imports are not suggested in your IDE.
  • in some IDE the typings are not always reflected properly

As alternatives, you can use:

  • relative paths instead of absolute paths (e.g. ../styled-system/css instead of styled-system/css)
  • use package.json #imports and/or tsconfig path aliases (prefer
    package.json#imports when possible, TS 5.4 supports them by default) like #styled-system/css instead of
    styled-system/css
  • for a component library, use a dedicated workspace package
    (e.g. @acme/styled-system) and use importMap: "@acme/styled-system" so that Panda knows which entrypoint to
    extract, e.g. import { css } from '@acme/styled-system/css'

Copy link

changeset-bot bot commented Mar 3, 2024

🦋 Changeset detected

Latest commit: 2aa66c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@pandacss/types Minor
@pandacss/dev Minor
@pandacss/config Minor
@pandacss/core Minor
@pandacss/fixture Minor
@pandacss/generator Minor
@pandacss/logger Minor
@pandacss/node Minor
@pandacss/parser Minor
@pandacss/preset-atlaskit Minor
@pandacss/preset-base Minor
@pandacss/preset-open-props Minor
@pandacss/preset-panda Minor
@pandacss/studio Minor
@pandacss/token-dictionary Minor
@pandacss/postcss Minor
@pandacss/astro-plugin-studio Minor
@pandacss/extractor Minor
@pandacss/is-valid-prop Minor
@pandacss/shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Mar 3, 2024 3:34pm
panda-playground ✅ Ready (Inspect) Visit Preview Mar 3, 2024 3:34pm
panda-studio ✅ Ready (Inspect) Visit Preview Mar 3, 2024 3:34pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants