add tests

chanzuckerberg · Nov 30, 2023 · c3f9873 · c3f9873
1 parent 104e6f3
commit c3f9873
Show file tree

Hide file tree

Showing 3 changed files with 72 additions and 1 deletion.
diff --git a/frontend/src/common/constants/routes.ts b/frontend/src/common/constants/routes.ts
@@ -17,6 +17,7 @@ export enum ROUTES {
   SITEMAP = "/sitemap",
   CELL_GUIDE = "/cellguide",
   CELL_GUIDE_CELL_TYPE = "/cellguide/:cellTypeId",
+  CELL_GUIDE_TISSUE = "/cellguide/tissues/:tissueId",
   CELL_GUIDE_TISSUE_SPECIFIC_CELL_TYPE = "/cellguide/tissues/:tissueId/cell-types/:cellTypeId",
   DEPLOYED_VERSION = "/api/deployed_version",
 }
diff --git a/frontend/src/views/CellGuide/components/CellGuideInfoSideBar/index.tsx b/frontend/src/views/CellGuide/components/CellGuideInfoSideBar/index.tsx
@@ -3,7 +3,6 @@ import { RightSidebarProperties } from "src/components/common/RightSideBar";
 import { CellType } from "../common/OntologyDagView/common/types";
 import Description from "../CellGuideCard/components/Description";
 import MarkerGeneTables from "../CellGuideCard/components/MarkerGeneTables";
-import { ROUTES } from "src/common/constants/routes";
 import { MarkerGeneTableWrapper, StyledLink } from "./style";
 import {
   CELLGUIDE_VIEW_PAGE_SIDEBAR_BUTTON_TEST_ID,

diff --git a/frontend/tests/features/cellGuide/cellGuide.test.ts b/frontend/tests/features/cellGuide/cellGuide.test.ts
@@ -79,6 +79,8 @@ const T_CELL_CELL_TYPE_ID = "CL_0000084";
 const BRAIN_TISSUE_ID = "UBERON_0000955";
 const LUNG_TISSUE_ID = "UBERON_0002048";
 const ABNORMAL_CELL_TYPE_ID = "CL_0001061";
+const PROGENITOR_CELL_CELL_TYPE_ID = "CL_0011026";
+const NATIVE_CELL_CELL_TYPE_ID = "CL_0000003";
 
 describe("Cell Guide", () => {
   describe("Landing Page", () => {
@@ -575,6 +577,74 @@ describe("Cell Guide", () => {
     });
 
     describe("Ontology Viewer", () => {
+      describe("Tissue specific cell type page", () => {
+        test("Clicks on a cell type node that has the same tissue in its dropdown in the ontology viewer navigates to the correct cell type page", async ({
+          page,
+        }) => {
+          await goToPage(
+            `${TEST_URL}${ROUTES.CELL_GUIDE_TISSUE.replace(
+              ":tissueId",
+              BRAIN_TISSUE_ID
+            )}`,
+            page
+          );
+
+          await Promise.all([
+            page.waitForURL(
+              `${TEST_URL}${ROUTES.CELL_GUIDE_TISSUE_SPECIFIC_CELL_TYPE.replace(
+                ":tissueId",
+                BRAIN_TISSUE_ID
+              ).replace(":cellTypeId", PROGENITOR_CELL_CELL_TYPE_ID)}`
+            ),
+            page.getByText("progenitor cell").click(),
+          ]);
+
+          await tryUntil(
+            async () => {
+              const dropdownText = await page
+                .getByTestId(CELL_GUIDE_CARD_GLOBAL_TISSUE_FILTER_DROPDOWN)
+                .textContent();
+
+              expect(dropdownText).toBe("brain");
+            },
+            { page }
+          );
+        });
+
+        test("Clicks on a cell type node that does NOT have the same tissue in its dropdown in the ontology viewer navigates to the generic cell type page", async ({
+          page,
+        }) => {
+          await goToPage(
+            `${TEST_URL}${ROUTES.CELL_GUIDE_TISSUE.replace(
+              ":tissueId",
+              BRAIN_TISSUE_ID
+            )}`,
+            page
+          );
+
+          await Promise.all([
+            page.waitForURL(
+              `${TEST_URL}${ROUTES.CELL_GUIDE_CELL_TYPE.replace(
+                ":cellTypeId",
+                NATIVE_CELL_CELL_TYPE_ID
+              )}`
+            ),
+            page.getByText("native cell").click(),
+          ]);
+
+          await tryUntil(
+            async () => {
+              const dropdownText = await page
+                .getByTestId(CELL_GUIDE_CARD_GLOBAL_TISSUE_FILTER_DROPDOWN)
+                .textContent();
+
+              expect(dropdownText).toBe("Tissue Agnostic");
+            },
+            { page }
+          );
+        });
+      });
+
       test("Clicking on a parent node expands and collapses its children", async ({
         page,
       }) => {
@@ -841,6 +911,7 @@ describe("Cell Guide", () => {
         expect(newTooltipText).not.toContain(`${geneSymbol} stats`);
       });
     });
+
     describe("Tissue Card", () => {
       test("All tissue card components are present", async ({ page }) => {
         await goToPage(