Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: marker genes unavailable for cell types <25 #3825

Merged
merged 6 commits into from
Jan 3, 2023
Merged

feat: marker genes unavailable for cell types <25 #3825

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89648d5
feat: marker genes unavailable for cell types <25
ashin-czi Dec 21, 2022
b714366
Merge branch 'main' into ashin-czi/3689-under-25-cells
atarashansky Jan 3, 2023
fc98641
- reverting changes to right sidebar for FMG
ashin-czi Jan 3, 2023
d348fb0
Merge branch 'ashin-czi/3689-under-25-cells' of https://github.com/ch…
ashin-czi Jan 3, 2023
0a08af9
returning null for cell_type count < 25
ashin-czi Jan 3, 2023
198e2bf
Merge branch 'main' into ashin-czi/3689-under-25-cells
ashin-czi Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/src/views/WheresMyGene/components/HeatMap/components/YAxisChart/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,18 +212,19 @@ export default memo(function YAxisChart({
isMarkerGenes &&
yAxisInfoCoords.map((coord, i) => {
const content = cellTypeMetadata[i];
const cellType = isMarkerGenes ? deserializeCellTypeMetadata(content) : null;
return (
<InfoButtonWrapper
id={content}
key={content}
left={coord[0]}
top={coord[1]}
onClick={() => {
if (isMarkerGenes) {
const cellType = deserializeCellTypeMetadata(content);
if (cellType) {
generateMarkerGenes(cellType, tissueID);
}
}}
style={cellType && cellType.total_count < 25 ? {visibility: "hidden"} : {}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just return null instead of visibility: "hidden" 😄 ? hidden is good if we expect to unhide the DOM element after user interaction, but that doesn't seem to be the case here, so we can save some memory and CPU cycle on rendering unused elements 👌 !

>
<StyledImage
id={"marker-gene-button"}
Expand Down