chore: 5397 Upgrade Next.js from v12 to v14 #6510
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -236,7 +236,6 @@ const DatasetRow: FC<Props> = ({ | |
| /> | ||
| {hasCXGFile(dataset) && ( | ||
| <Tooltip | ||
|
There was a problem hiding this comment. @MillenniumFalconMechanic @frano-m it doesn't seem like we need to specify PTAL if I missed anything lol 🙏 Thank you! 
There was a problem hiding this comment. Hi @tihuan, this looks good to me! As a side note, I am seeing a warning in the console - when hovering over the NTag and Explore button. Are you seeing this as well?
|
||
| content={OVER_MAX_CELL_COUNT_TOOLTIP} | ||
| disabled={!isOverMaxCellCount} | ||
| intent={Intent.DANGER} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { Dialog } from "@blueprintjs/core"; | ||
| import loadable from "@loadable/component"; | ||
| import * as React from "react"; | ||
| import { FC, useState } from "react"; | ||
|
|
@@ -11,6 +11,7 @@ import { useUserInfo } from "src/common/queries/auth"; | |
| import { removeParams } from "src/common/utils/removeParams"; | ||
| import { StyledButton } from "./style"; | ||
| import { useRouter } from "next/router"; | ||
| import { ButtonProps } from "@czi-sds/components"; | ||
|
|
||
| const AsyncContent = loadable( | ||
| () => | ||
|
|
@@ -24,7 +25,7 @@ const AsyncCTA = loadable( | |
| /*webpackChunkName: 'CreateCollectionModalCTA' */ import("./components/CTA") | ||
| ); | ||
|
|
||
| const CreateCollectionButton = (props: Partial<ButtonProps>) => ( | ||
| <StyledButton sdsStyle="square" sdsType="primary" {...props}> | ||
|
There was a problem hiding this comment. Nice pick up thanks @tihuan! ⭐ |
||
| Create Collection | ||
| </StyledButton> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| import React from "react"; | ||
| import Link from "next/link"; | ||
| import { ROUTES } from "src/common/constants/routes"; | ||
| import { track } from "src/common/analytics"; | ||
| import { EVENTS } from "src/common/analytics/events"; | ||
| import NavDivider from "src/components/Header/components/Nav/components/NavDivider"; | ||
|
|
@@ -24,58 +23,42 @@ export default function Nav({ className, pathname }: Props): JSX.Element { | |
| <NavSection> | ||
| <NavSectionTitle>Application</NavSectionTitle> | ||
| <NavItemContainer> | ||
|
There was a problem hiding this comment. @seve I removed |
||
| <LinkWrapper | ||
| isActive={isRouteActive(pathname, ROUTES.COLLECTIONS)} | ||
| data-testid="collections-link" | ||
| onClick={() => { | ||
| track(EVENTS.COLLECTIONS_CLICK_NAV); | ||
| }} | ||
| > | ||
| <Link href={ROUTES.COLLECTIONS}>Collections</Link> | ||
| </LinkWrapper> | ||
| <LinkWrapper | ||
| isActive={isRouteActive(pathname, ROUTES.DATASETS)} | ||
| onClick={() => { | ||
| track(EVENTS.DATASETS_CLICK_NAV); | ||
| }} | ||
| > | ||
| <Link href={ROUTES.DATASETS}>Datasets</Link> | ||
| </LinkWrapper> | ||
| <LinkWrapper | ||
| isActive={isRouteActive(pathname, ROUTES.WHERE_IS_MY_GENE)} | ||
| > | ||
| <Link | ||
| href={ROUTES.WHERE_IS_MY_GENE} | ||
| onClick={() => { | ||
| track(EVENTS.WMG_CLICK_NAV); | ||
| }} | ||
| > | ||
| Gene Expression | ||
| </Link> | ||
| </LinkWrapper> | ||
| <LinkWrapper | ||
| isActive={isRouteActive(pathname, ROUTES.CELL_GUIDE)} | ||
| onClick={() => { | ||
| track(EVENTS.CELL_GUIDE_CLICK_NAV); | ||
| }} | ||
| > | ||
| <Link href={ROUTES.CELL_GUIDE}>Cell Guide</Link> | ||
| <BetaChip label="Beta" size="small" /> | ||
| </LinkWrapper> | ||
| </NavItemContainer> | ||
|
|
@@ -84,30 +67,22 @@ export default function Nav({ className, pathname }: Props): JSX.Element { | |
| <NavSection> | ||
| <NavSectionTitle>Census</NavSectionTitle> | ||
| <NavItemContainer> | ||
| <LinkWrapper isActive={false}> | ||
| <a | ||
| onClick={() => track(EVENTS.CENSUS_DOCUMENTATION_CLICK_NAV)} | ||
| href={CENSUS_LINK} | ||
| rel="noopener noreferrer" | ||
| > | ||
| API | ||
| </a> | ||
| </LinkWrapper> | ||
| <LinkWrapper | ||
| isActive={isRouteActive(pathname, ROUTES.CENSUS_DIRECTORY)} | ||
| onClick={() => { | ||
| track(EVENTS.CENSUS_DIRECTORY_CLICK_NAV); | ||
| }} | ||
| > | ||
| <Link href={ROUTES.CENSUS_DIRECTORY}>Models</Link> | ||
| </LinkWrapper> | ||
| </NavItemContainer> | ||
| </NavSection> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nextjs built in https local FE server creates certs in this directory