Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing python3.7 on Ubuntu 20.04 LTS #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

e1mo
Copy link
Member

@e1mo e1mo commented Sep 6, 2020

When doing a clean run on Ubuntu 20.04 LTS the maubot role attempts to
install python3.7 and the corresponding venv package. In Ubuntu 20.04
however, python3.7 is no longer available. The default is python3.8.
Therefore I would propose switching over to python3 in general.

This has been testet to work on Ubuntu 20.04 LTS, but not on older
versions. Therefore, further tests need to be done.

When doing a clean run on Ubuntu 20.04 LTS the maubot role attempts to
install `python3.7` and the corresponding venv package. In Ubuntu 20.04
however, `python3.7` is no longer available. The default is `python3.8`.
Therefore I would propose switching over to `python3` in general.

This has been testet to work on Ubuntu 20.04 LTS, but not on older
versions. Therefore, further tests need to be done.
@e1mo e1mo added bug Something isn't working service/maubot labels Sep 6, 2020
Copy link
Contributor

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use python3 because on Ubuntu 18.04 (currently in usage on production) the python3 package is on version 3.6.7, but in version 3.7 a feature is introduced maubot needs (see https://docs.python.org/3/library/datetime.html#technical-detail, 0b0c65a)

@e1mo
Copy link
Member Author

e1mo commented Sep 6, 2020

What about using ansible_distribution_major_version and ansible_distribution to check if we are beyond Ubuntu 18.04. and install the corresponding packages and execute the appropriate commands.

If that sounds promissing, I could write something up the next couple of days.

@YtvwlD
Copy link
Member

YtvwlD commented Sep 6, 2020

Why don't just go to Python 3.8 on both Ubuntu versions?

@e1mo e1mo changed the base branch from master to main September 9, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working service/maubot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants