Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GitHub actions regularly and run colmena #35

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

e1mo
Copy link
Member

@e1mo e1mo commented Feb 5, 2024

The regular runs are intended to just keep the caches fresh to reduce build times on future Pull-Requests. Running colmena build is only added to ensure that there are no issues in the colmena config.

Just to ensure our caches won't get pruned in orer to keep build times
on PRs somewhat lower
@e1mo e1mo requested a review from a team as a code owner February 5, 2024 11:29
@e1mo e1mo force-pushed the gh-actions-improvements branch 2 times, most recently from 38b3c8c to 807dec7 Compare February 6, 2024 12:43
@e1mo e1mo marked this pull request as draft February 6, 2024 12:43
@e1mo e1mo force-pushed the gh-actions-improvements branch 3 times, most recently from 5f6b241 to 39b29c5 Compare February 6, 2024 13:13
Copy link
Member

@YtvwlD YtvwlD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any experience with either flakes, cron or colmena, so I can't really comment on this. But it doesn't look completely wrong, at least.

Git treats the path as absolute whilst, at leas to my understanding, the
nix flake manual specifies that this ath can be relative. Thus
explicitly setting the current working directory as the path.
@e1mo e1mo marked this pull request as ready for review February 15, 2024 18:56
@e1mo e1mo merged commit c5c1b22 into main Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants