-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2 of TubeMark? #1
Open
deanrobertcook
wants to merge
52
commits into
chaosifier:master
Choose a base branch
from
deanrobertcook:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync storage only allows up to 100KB! local allows up to 5MB, which is still not much...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chaosifier,
sorry for the delay, I got a bit slow doing all the boring stuff like tidying up my changes ;)
I still need to update the screenshots, which I'll try later this week, but the bulk of the work is there if you want to have a look at it more closely. I know I've changed a lot here, since I wasn't originally planning on merging this stuff back to your fork, but hopefully you still like it all! If there's anything you're unsure of or don't like, please don't hesitate to leave a comment.
I'm not sure of the process for uploading the changes to the chrome web store, or if I need any permissions from you, but maybe we can aim to get it up in the next week?
Looking forward to your feedback!