Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OffscreenCanvas documentation, as it is widely available now #11823

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

joliss
Copy link
Contributor

@joliss joliss commented Jun 29, 2024

As documented by MDN, OffscreenCanvas is widely available as of 2023, so this pull request updates the documentation accordingly.

I tested rendering with OffScreenCanvas on my own app, and it works with Chrome and Firefox.

However, in Safari 17.5 and 18.0-preview on macOS, it doesn't render anything for me when I switch from canvas to canvas.transferControlToOffscreen(). There's unfortunately no error message in the console. I wasn't able to reproduce my problem with a simple test case -- the CodePen works fine in Safari -- so don't really have a good bug report to submit. I think it's also quite possible that there's something else going on in my code that Safari is tripping over.

So perhaps for the moment, it might be worth merging this documentation patch. If people run into issues with Safari (or I can reproduce my issue with a smaller example) down the line, we can always open a new issue for it then.

@etimberg etimberg added this to the 4.5.0 milestone Jun 29, 2024
@LeeLenaleee LeeLenaleee merged commit 0ca1b6e into chartjs:master Jun 30, 2024
5 checks passed
@blueyedblues
Copy link

blueyedblues commented Jul 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants