Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(bot): cut_body_before option for merge message #589

Merged
merged 16 commits into from
Dec 10, 2020
Merged

add(bot): cut_body_before option for merge message #589

merged 16 commits into from
Dec 10, 2020

Conversation

scriptnull
Copy link
Contributor

@scriptnull scriptnull commented Dec 9, 2020 •
edited
Loading

Addresses #550

I had been fully dependent on the CI environment for testing this PR since I had trouble setting up my local development machine.

@netlify
Copy link

netlify bot commented Dec 9, 2020 •
edited
Loading

Deploy request for kodiak-docs pending review.

Review with commit c546b98

https://app.netlify.com/sites/kodiak-docs/deploys

@scriptnull
Copy link
Contributor Author

This is now ready for a review!

chdsbd
chdsbd reviewed Dec 10, 2020
View reviewed changes
Copy link
Owner

@chdsbd chdsbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I'm sorry about the dev environment trouble.

bot/kodiak/test_evaluation.py Show resolved Hide resolved
docs/docs/config-reference.md Outdated Show resolved Hide resolved
bot/kodiak/evaluation.py Outdated Show resolved Hide resolved
@scriptnull scriptnull mentioned this pull request Dec 10, 2020
Merged
@chdsbd chdsbd changed the title introduces cut_body_before option for merge message add(bot): cut_body_before option for merge message Dec 10, 2020
@chdsbd chdsbd added the automerge Mark PR for auto merge by Kodiak label Dec 10, 2020
@chdsbd
Copy link
Owner

chdsbd commented Dec 10, 2020

Thanks for the PR! I'll update #550 when this change is deployed.

@kodiakhq kodiakhq bot merged commit acfd35d into chdsbd:master Dec 10, 2020
@scriptnull scriptnull deleted the commit-message-from-pr branch December 10, 2020 05:16
sbdchd added a commit that referenced this pull request Dec 12, 2020
@sbdchd
add(bot): cut_body_after option for merge message
e8d3587 
`cut_body_before` was added via #589

Add the second option, also handle the case where the match isn't found.

rel: #550
@sbdchd sbdchd mentioned this pull request Dec 12, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request Dec 12, 2020
@sbdchd
add(bot): cut_body_after option for merge message (#595)
6a7d0af 
`cut_body_before` was added via #589

Add the second option, also handle the case where the match isn't found.

rel: #550
kodiakhq bot pushed a commit that referenced this pull request Dec 13, 2020
@scriptnull
add(docs): docs for cut_body_before and cut_body_after options (#591)
a9a31c9 
Documentation for features added in #589 and #595.
@chdsbd chdsbd mentioned this pull request Dec 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chdsbd chdsbd chdsbd approved these changes

Assignees
No one assigned
Labels
automerge Mark PR for auto merge by Kodiak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scriptnull @chdsbd