Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New RetryError class, add maximumBackoff #24

Merged
merged 4 commits into from
Apr 8, 2024
Merged

New RetryError class, add maximumBackoff #24

merged 4 commits into from
Apr 8, 2024

Conversation

carlansley
Copy link
Contributor

Fixes #20
Fixes #22
Fixes #23

@carlansley carlansley self-assigned this Apr 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Coverage after merging new-retry-error-class into main will be

88.65%▾ -0.51%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   error.ts100%100%100%100%
   index.ts100%100%100%100%
   options.ts0%0%0%0%1, 1, 10–14, 2–9
   retry.ts97.46%94.44%100%97.96%56–58

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Beta Published - Install Command: npm install @checkdigit/retry@6.0.0-PR.24-6d7b

le-cong
le-cong approved these changes Apr 4, 2024
View reviewed changes
Copy link

@le-cong le-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ramaghanta
ramaghanta approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@ramaghanta ramaghanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

✅ PR review status - All reviews completed and approved!

@carlansley carlansley merged commit 717c0a9 into main Apr 8, 2024
9 of 10 checks passed
@carlansley carlansley deleted the new-retry-error-class branch April 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le-cong le-cong le-cong approved these changes

@ramaghanta ramaghanta ramaghanta approved these changes

Assignees

@carlansley carlansley

Labels
MAJOR
Projects
None yet
Milestone
No milestone
3 participants
@carlansley @le-cong @ramaghanta