Skip to content

Commit

Permalink
fix(ci/check-size): use latest non-merge commit
Browse files Browse the repository at this point in the history
We were previously using the merge commit as the baseline, leading to
all commits from the pull request being rebased, rather than just the
latest commit.

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
  • Loading branch information
snprajwal committed Jun 16, 2023
1 parent 5bb5902 commit d054676
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/check-size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ jobs:
- name: Configure base branch without switching current branch
run: git fetch origin ${GITHUB_BASE_REF}:${GITHUB_BASE_REF}
- name: Compare binary size change across each commit
run: git rebase -v ${GITHUB_BASE_REF}^ -x test/check-size.sh
# Use the last non-merge commit from the base branch as the baseline
run: git rebase -v $(git rev-list --no-merges -n 1 ${GITHUB_BASE_REF})^ -x test/check-size.sh

0 comments on commit d054676

Please sign in to comment.