Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memparse: show process shared memory size #103

Merged
merged 2 commits into from
Sep 1, 2023
Merged

memparse: show process shared memory size #103

merged 2 commits into from
Sep 1, 2023

Conversation

behouba
Copy link
Collaborator

@behouba behouba commented Aug 31, 2023

This PR add a new column to the memparse table, which displays the shared memory size of each process within the checkpoint.

Example:

# checkpointctl memparse /tmp/mysql.tar.gz 

Displaying processes memory sizes from /tmp/checkpoints/mysql.tar.gz

+-----+--------------+-------------+--------------------+
| PID | PROCESS NAME | MEMORY SIZE | SHARED MEMORY SIZE |
+-----+--------------+-------------+--------------------+
|   1 | mysqld       | 349.7 MiB   | 188.0 KiB          |
+-----+--------------+-------------+--------------------+

@behouba
chore(deps): update go-criu
6e4a243 
Signed-off-by: Kouame Behouba Manasse <behouba@gmail.com>
@behouba
memparse: show process shared memory size
a68feae 
This commit introduces a new column to the 'memparse' sub-command table, which
displays the shared memory size of each process within the checkpoint.

Signed-off-by: Kouame Behouba Manasse <behouba@gmail.com>
@github-actions
Copy link

Test Results

48 tests  ±0   48 ✔️ ±0   1s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a68feae. ± Comparison against base commit 3d698f3.

rst0git
rst0git approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rst0git rst0git merged commit e8f4c75 into checkpoint-restore:main Sep 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rst0git rst0git rst0git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behouba @rst0git