refactor: move table rendering into own funcs #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 80.31% 80.56% +0.25%
==========================================
Files 3 3
Lines 386 391 +5
==========================================
+ Hits 310 315 +5
Misses 55 55
Partials 21 21
☔ View full report in Codecov by Sentry. |
snprajwal
force-pushed
the
refactor
branch
2 times, most recently
from
590b3c8
to
b0fd761
Compare
The logic for rendering tables with the checkpoint data was all present in a single function `showContainerCheckpoint()`. This has now been refactored to provide each table its own function that can be called to render it. This increases code maintainability going forward as more and more tables are added to the `checkpointctl show` command. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
The flag variables for the CLI were previously using either `print` or `show` prefixes. This is not required as they are booleans used to indicate if the flag is enabled. The names have now been made consistent to enable future flag variables to be named idiomatically. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
adrianreber
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for rendering tables with the checkpoint data was all present
in a single function
showContainerCheckpoint(). This has now beenrefactored to provide each table its own function that can be called to
render it. This increases code maintainability going forward as more and
more tables are added to the
checkpointctl showcommand.