Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display sockets in process tree #94

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

snprajwal
Copy link
Member

@snprajwal snprajwal commented Jul 28, 2023

This is now supported with the --sockets flag.

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

Test Results

48 tests  +2   48 ✔️ +2   1s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 4ff6bb7. ± Comparison against base commit a699e2d.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Patch coverage: 49.27% and project coverage change: -3.18% ⚠️

Comparison is base (9c2098c) 82.30% compared to head (bafb3cc) 79.12%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   82.30%   79.12%   -3.18%     
==========================================
  Files           6        6              
  Lines         842      915      +73     
==========================================
+ Hits          693      724      +31     
- Misses        111      150      +39     
- Partials       38       41       +3     
Files Changed Coverage Δ
tree.go 69.94% <25.53%> (-18.03%) ⬇️
checkpointctl.go 93.90% <100.00%> (+0.42%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snprajwal snprajwal marked this pull request as ready for review August 8, 2023 17:17
tree.go Outdated Show resolved Hide resolved
@snprajwal
Copy link
Member Author

Is Codecov broken? It seems to not update the coverage, or report the status via CI anymore

@rst0git
Copy link
Member

rst0git commented Aug 10, 2023

Is Codecov broken? It seems to not update the coverage, or report the status via CI anymore

It seems to work:

@snprajwal
Copy link
Member Author

Ah, the Codecov comment has been edited now for the latest force push. It wasn't doing that for the previous force pushes though (edit history says this is the first edit in two weeks). Weird. Anyway, glad to know it works

@snprajwal snprajwal requested a review from rst0git August 10, 2023 13:14
@adrianreber
Copy link
Member

I have also seen cases where the codecov comment was not updated in other PRs. Seems to happen sometimes.

tree.go Outdated Show resolved Hide resolved
tree.go Outdated Show resolved Hide resolved
tree.go Outdated Show resolved Hide resolved
tree.go Outdated Show resolved Hide resolved
This is now supported with the `--sockets` flag.

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@rst0git rst0git merged commit 3d698f3 into checkpoint-restore:main Aug 14, 2023
10 checks passed
@snprajwal snprajwal deleted the add-sk branch September 6, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants