Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect: enable --ps-tree-{env,cmd} with --all #96

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

rst0git
Copy link
Member

@rst0git rst0git commented Aug 4, 2023

This patch enables --ps-tree-cmd and --ps-tree-env options when the inspect command is used with --all. This change provides more complete information about the processes included in a container checkpoint.

@rst0git
Copy link
Member Author

rst0git commented Aug 4, 2023

@behouba @snprajwal PTAL

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Test Results

42 tests  ±0   42 ✔️ ±0   1s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 0c9c60f. ± Comparison against base commit 8e4f577.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@behouba behouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I believe that some tests need to be updated.

This patch enables `--ps-tree-cmd` and `--ps-tree-env` options when the
`inspect` command is used with `--all`. This change provides more
complete information about the processes included in a container
checkpoint.

Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (8e4f577) 82.78% compared to head (0c9c60f) 82.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   82.78%   82.80%   +0.02%     
==========================================
  Files           4        4              
  Lines         633      634       +1     
==========================================
+ Hits          524      525       +1     
  Misses         80       80              
  Partials       29       29              
Files Changed Coverage Δ
checkpointctl.go 93.10% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rst0git rst0git merged commit 002ac82 into checkpoint-restore:main Aug 4, 2023
10 checks passed
@rst0git rst0git deleted the inspect-all branch August 4, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants