Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update go version #110

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

rst0git
Copy link
Member

@rst0git rst0git commented Mar 27, 2023

Go 1.17.x will be removed and 1.20.x set as default in the GitHub action virtual environment on April 3, 2023.
actions/runner-images#7276

Copy link
Member

@snprajwal snprajwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can merge it directly and allow the lint run to succeed on master, or you can rebase if you prefer having it succeed before the merge.

@rst0git rst0git force-pushed the update-go-version branch 3 times, most recently from 170a65a to 81dbb32 Compare April 4, 2023 12:00
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6360361) 50.68% compared to head (bb57eba) 50.68%.

❗ Current head bb57eba differs from pull request most recent head 4e85083. Consider uploading reports for the commit 4e85083 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   50.68%   50.68%           
=======================================
  Files           2        2           
  Lines         292      292           
=======================================
  Hits          148      148           
  Misses        108      108           
  Partials       36       36           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rst0git
Copy link
Member Author

rst0git commented Apr 4, 2023

@adrianreber We might need to update the list of workflows in the Require status checks to pass before merging branch protection rule for the go-criu repository.

Go 1.17.x will be removed and 1.20.x set as default in the GitHub action
virtual environment on April 3, 2023.

Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@adrianreber
Copy link
Member

I adapted the branch protection rules.

@adrianreber adrianreber merged commit a976c4a into checkpoint-restore:master Apr 4, 2023
@rst0git rst0git deleted the update-go-version branch April 4, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants