Update css-select to the latest version 🚀 (#1158)

Breaking change: Invalid selectors now throw Errors, not SyntaxErrors.
cheeriojs · Sep 9, 2020 · c1a5e5e · c1a5e5e
1 parent fe0f903
commit c1a5e5e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -25,7 +25,7 @@
     "node": ">= 0.6"
   },
   "dependencies": {
-    "css-select": "~1.2.0",
+    "css-select": "~2.0.0",
     "dom-serializer": "~0.1.0",
     "entities": "~1.1.1",
     "htmlparser2": "^3.9.1",

diff --git a/test/api/traversing.js b/test/api/traversing.js
@@ -60,10 +60,13 @@ describe('$(...)', function() {
       expect(q('[alltheway]')).to.have.length(0);
     });
 
-    it('should throw a SyntaxError if given an invalid selector', function() {
+    it('should throw an Error if given an invalid selector', function() {
       expect(function() {
         $('#fruits').find(':bah');
-      }).to.throwException(/unmatched pseudo-class/);
+      }).to.throwException(function(err) {
+        expect(err).to.be.a(Error);
+        expect(err.message).to.contain('unmatched pseudo-class')
+      });
     });
 
     describe('(cheerio object) :', function() {
@@ -451,10 +454,13 @@ describe('$(...)', function() {
       expect($('.orange').siblings('.peach')).to.have.length(0);
     });
 
-    it('(selector) : should throw a SyntaxError if given an invalid selector', function() {
+    it('(selector) : should throw an Error if given an invalid selector', function() {
       expect(function() {
         $('.orange').siblings(':bah');
-      }).to.throwException(/unmatched pseudo-class/);
+      }).to.throwException(function(err) {
+        expect(err).to.be.a(Error);
+        expect(err.message).to.contain('unmatched pseudo-class')
+      });
     });
 
     it('(selector) : does not consider the contents of siblings when filtering (GH-374)', function() {