refactor(traversing): Wrap shared behavior #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revival of #1731 Co-Authored-By: 5saviahv <49443574+5saviahv@users.noreply.github.com>
|
Nice, I am happy ... sadly I am not very good in this typescript stuff. I try keep up but train is moving way too fast :) Nice Work |
No worries, and I can see how TS can be a bit intimidating at first. Happy to help with types, should you feel like cooking up some more PRs :) |
This was referenced Aug 31, 2024
This was referenced Sep 1, 2024
This was referenced Sep 8, 2024
This was referenced Sep 12, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of #1731
@5saviahv As this is based on your work, I'd appreciate if you could have a look!