Honors accept_license for the Chef Infra Server install #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
removed some commits from the PR which should not have been in there |
|
Any updates on this? |
|
This requires a DCO sign-off or we can't accept it due to licensing questions. https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco |
tas50
added
the
Status: Waiting on Contributor
|
@tas50 Thank you for the response. Is it safe to assume that @mrmarbury already abandoned this pull request? Nonetheless, I already created a separate pull request with my DCO. #169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new Chef Infra Server you have to accept the license to install it. This was not possible before
INFO: Does not work without PR chef-cookbooks/chef-ingredient#241
Issues Resolved
Check List
delivery local allsucceedskitchen testsucceeds