added review comment changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>
chef · Feb 9, 2022 · 5429822 · 5429822
1 parent fc32e22
commit 5429822
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 25 deletions.
diff --git a/...ate-ui/src/app/modules/infra-proxy/chef-server-details/chef-server-details.component.html b/...ate-ui/src/app/modules/infra-proxy/chef-server-details/chef-server-details.component.html
@@ -10,8 +10,8 @@
       </chef-breadcrumbs>
       <chef-page-header>
         <div class="meta-box">
+          <p class="chef-server-info-text">CHEF SERVER INFORMATION</p>
           <div class="summary-body first">
-            <chef-heading data-cy="page-title">{{ server?.name }}</chef-heading>
             <ul>
               <li>
                 <span class="heading">FQDN</span>
@@ -21,6 +21,10 @@
                 <span class="heading">IP Address</span>
                 <span class="server-entity-value">{{ server?.ip_address === '' ? '--' : server?.ip_address }}</span>
               </li>
+              <li>
+                <span class="heading"></span>
+                <span class="server-entity-value"></span>
+              </li>
             </ul>
           </div>
           <div class="summary-body middle">
@@ -79,7 +83,7 @@
                     />
                   </svg>
                   <span>{{stepsCompleted}} Steps Completed</span>
-                  <span *ngIf="true"><a
+                  <span *ngIf="migrationIsInPreview"><a
                     data-cy="show-preview"
                     class="preview-link"
                     >Click to Preview</a>

diff --git a/...ate-ui/src/app/modules/infra-proxy/chef-server-details/chef-server-details.component.scss b/...ate-ui/src/app/modules/infra-proxy/chef-server-details/chef-server-details.component.scss
@@ -18,7 +18,7 @@ chef-page-header {
     padding: 0 1em;
 
     &.first {
-      width: 40%;
+      width: 39%;
 
       .heading {
         display: inline-block;
@@ -32,7 +32,7 @@ chef-page-header {
     }
 
     &.middle {
-      width: 45%;
+      width: 46%;
 
       .heading {
         display: inline-block;
@@ -95,7 +95,7 @@ chef-page-header {
 
     .sync-button {
       float: right;
-      margin-bottom: -16px;
+      margin-bottom: 62px;
 
       .img-inline {
         width: 17px;
@@ -284,26 +284,11 @@ img {
 .status-icon-completed {
   position: absolute;
   margin-top: 0px;
-
-  // &::before {
-  //   font-family: "Material Icons";
-  //   content: "\E86C";  // circle-check icon - https://material.io/resources/icons/?icon=check_circle&style=baseline
-  //   color: #3864F1;
-  //   padding-right: 0.5em;
-  //   font-size: 17px;
-  // }
 }
+
 .status-icon-failed {
   position: absolute;
   margin-top: 0px;
-
-  // &::before {
-  //   font-family: "Material Icons";
-  //   content: "\e000";  // circle-check icon - https://material.io/resources/icons/?icon=check_circle&style=baseline
-  //   color: #E0408A;
-  //   padding-right: 0.5em;
-  //   font-size: 17px;
-  // }
 }
 
 .preview-link {
@@ -317,3 +302,7 @@ img {
   font-size: 10px;
   color: #ba1e6a;
 }
+
+.chef-server-info-text {
+  margin-left: 14px;
+}
diff --git a/...omate-ui/src/app/modules/infra-proxy/chef-server-details/chef-server-details.component.ts b/...omate-ui/src/app/modules/infra-proxy/chef-server-details/chef-server-details.component.ts
@@ -96,7 +96,7 @@ export class ChefServerDetailsComponent implements OnInit, OnDestroy {
   public migrationID: string;
   public migrationStatus: MigrationStatus;
   public migrationStatusPercentage: number;
-  public stepsCompleted: string
+  public stepsCompleted: string;
   public totalMigrationSteps = 13;
   public migrationStepValue: number;
   public migrationfailed = false;
@@ -425,8 +425,8 @@ export class ChefServerDetailsComponent implements OnInit, OnDestroy {
               this.migrationCompleted = true;
               this.migrationInProgress = false;
             }
-            this.stepsCompleted =  this.migrationStepValue.toFixed(0) + '/' + '13'
-            if (migration_type == 'Creating Preview') {
+            this.stepsCompleted =  this.migrationStepValue.toFixed(0) + '/' + '13';
+            if (migration_type === 'Creating Preview') {
               this.migrationIsInPreview = true;
             }
           } else {
@@ -487,6 +487,6 @@ export class ChefServerDetailsComponent implements OnInit, OnDestroy {
     };
     this.store.dispatch(new UploadZip( uploadZipPayload ));
     this.migrationStarted = true;
-    this.getMigrationStatus(this.server.migration_id)
+    this.getMigrationStatus(this.server.migration_id);
   }
 }