Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the HAB_BLDR_CHANNEL to dev just for builds #5745

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

rickmarry
Copy link
Contributor

Signed-off-by: Rick Marry rmarry@chef.io

🔩 Description: What code changed, and why?

this is a follow up to pr 5741 where for hab package refresh, we need to set one env var to dev but just for builds.. we do so by making it a local var

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Rick Marry <rmarry@chef.io>
@netlify
Copy link

netlify bot commented Sep 17, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 3e46da9

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/614505f206064000075fcb85

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalroy kalroy assigned rickmarry and unassigned mwrock and kalroy Sep 20, 2021
@kalroy kalroy self-requested a review September 20, 2021 01:35
@kalroy kalroy merged commit 05a4b2e into main Sep 20, 2021
@kalroy kalroy deleted the rm/set-hab-bldr-channel-locally-for-build branch September 20, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants