Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to fix the migration UI pipeline #6908

Merged

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented Apr 13, 2022

Signed-off-by: Vinay Sharma vsharma@chef.io

🔩 Description: What code changed, and why?

The Infra chef-server migration process is not working properly, need to fix the below points

  • Org list is not loaded after refreshing or navigating the server details page
  • After confirming migration org list not showing
  • After uploading the backup zip file migration steps are not showing properly
  • On the server details page migration status is not showing properly
  • After canceling the migration, the status is showing failed instead of canceled.
  • Fixed for username conflict check
  • restricted confirm migration according to different conditions.

⛓️ Related Resources

https://chefio.atlassian.net/browse/STALWART-95
https://chefio.atlassian.net/browse/STALWART-102
https://chefio.atlassian.net/browse/STALWART-118
https://chefio.atlassian.net/browse/STALWART-112

👍 Definition of Done

I have added some changes to fix the above issues.

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Apr 13, 2022

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit aae0027
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6272264e0abcea0008978632

@vinay033 vinay033 force-pushed the Vinay/migration_ui_pipeline_fixes branch from 5de05ad to 39fe925 Compare April 14, 2022 17:17
@vinay033 vinay033 force-pushed the feature/infra_user_management branch from aa344f9 to 9594f88 Compare April 18, 2022 12:18
@vinay033 vinay033 requested a review from a team as a code owner April 18, 2022 12:18
@vinay033 vinay033 force-pushed the Vinay/migration_ui_pipeline_fixes branch 2 times, most recently from a00a235 to 5d30566 Compare April 19, 2022 10:32
Copy link
Contributor

@chaitali-mane chaitali-mane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration code fixed

@vinay033 vinay033 force-pushed the feature/infra_user_management branch from 7910e16 to dc2dbd0 Compare April 19, 2022 19:27
@vinay033 vinay033 force-pushed the Vinay/migration_ui_pipeline_fixes branch from 5d30566 to 5bc4287 Compare April 19, 2022 19:28
@vinay033 vinay033 force-pushed the feature/infra_user_management branch from 7e39a1d to 2f38f15 Compare April 22, 2022 09:53
@vinay033 vinay033 force-pushed the Vinay/migration_ui_pipeline_fixes branch 2 times, most recently from 473107f to fbc04e9 Compare April 28, 2022 00:10
@kalroy kalroy force-pushed the feature/infra_user_management branch from 073be91 to ef1e46a Compare April 28, 2022 08:21
@vinay033 vinay033 force-pushed the feature/infra_user_management branch from a8cdc10 to 2f89bbe Compare May 2, 2022 10:10
iamazzeez and others added 10 commits May 2, 2022 23:46
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
* Sync status

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Sync migration time

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@vinay033 vinay033 force-pushed the Vinay/migration_ui_pipeline_fixes branch from fbc04e9 to 0f0d364 Compare May 3, 2022 19:25
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vinay033 vinay033 merged commit 9c61f07 into feature/infra_user_management May 4, 2022
@vinay033 vinay033 deleted the Vinay/migration_ui_pipeline_fixes branch May 4, 2022 11:21
vinay033 added a commit that referenced this pull request May 4, 2022
* policyfiles actions added (#6081)

Signed-off-by: Abdul-Az <aazeez@progress.com>

* added policygroups actions (#6123)

Signed-off-by: Abdul-Az <aazeez@progress.com>

* Automate API needs to handle sync status (#6860)

* Sync status

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Sync migration time

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* changes to fix the migration UI pipeline

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some changes for conflicts

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added chanegs to fix the migration status

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some changes for code optimization

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added changes to fix the migration issue + check user conflicts

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added proto changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added temp changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* updated changes for migration process

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added changes to fix the user migration

Signed-off-by: Vinay Sharma <vsharma@chef.io>

Co-authored-by: Abdul Azeez <aazeez@progress.com>
Co-authored-by: Dave Augustus <95467821+dave-augustus@users.noreply.github.com>
vinay033 added a commit that referenced this pull request May 9, 2022
* policyfiles actions added (#6081)

Signed-off-by: Abdul-Az <aazeez@progress.com>

* added policygroups actions (#6123)

Signed-off-by: Abdul-Az <aazeez@progress.com>

* Automate API needs to handle sync status (#6860)

* Sync status

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Sync migration time

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* changes to fix the migration UI pipeline

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some changes for conflicts

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added chanegs to fix the migration status

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some changes for code optimization

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added changes to fix the migration issue + check user conflicts

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added proto changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added temp changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* updated changes for migration process

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added changes to fix the user migration

Signed-off-by: Vinay Sharma <vsharma@chef.io>

Co-authored-by: Abdul Azeez <aazeez@progress.com>
Co-authored-by: Dave Augustus <95467821+dave-augustus@users.noreply.github.com>
vinay033 added a commit that referenced this pull request May 12, 2022
* policyfiles actions added (#6081)

Signed-off-by: Abdul-Az <aazeez@progress.com>

* added policygroups actions (#6123)

Signed-off-by: Abdul-Az <aazeez@progress.com>

* Automate API needs to handle sync status (#6860)

* Sync status

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Sync migration time

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* changes to fix the migration UI pipeline

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some changes for conflicts

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added chanegs to fix the migration status

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some changes for code optimization

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added changes to fix the migration issue + check user conflicts

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added proto changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added temp changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* updated changes for migration process

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added changes to fix the user migration

Signed-off-by: Vinay Sharma <vsharma@chef.io>

Co-authored-by: Abdul Azeez <aazeez@progress.com>
Co-authored-by: Dave Augustus <95467821+dave-augustus@users.noreply.github.com>
vinay033 added a commit that referenced this pull request May 16, 2022
* policyfiles actions added (#6081)

Signed-off-by: Abdul-Az <aazeez@progress.com>

* added policygroups actions (#6123)

Signed-off-by: Abdul-Az <aazeez@progress.com>

* Automate API needs to handle sync status (#6860)

* Sync status

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Sync migration time

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* changes to fix the migration UI pipeline

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some changes for conflicts

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added chanegs to fix the migration status

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some changes for code optimization

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added changes to fix the migration issue + check user conflicts

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added proto changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added temp changes

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* updated changes for migration process

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added changes to fix the user migration

Signed-off-by: Vinay Sharma <vsharma@chef.io>

Co-authored-by: Abdul Azeez <aazeez@progress.com>
Co-authored-by: Dave Augustus <95467821+dave-augustus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants