Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor users are able to delete objects for an org #6924

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Editor users are able to delete objects for an org #6924

merged 2 commits into from
Apr 19, 2022

Conversation

GorillaGigabytes
Copy link
Contributor

Signed-off-by: Pappu Kumar pappu.kumar@progress.com

🔩 Description: What code changed, and why?

Editor users are able to delete objects for an org so we passed one project name in header

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

Run the following commands

  • cd components/automate-ui
  • make serve
    Try deleting objects from UI

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Editor users are able to delete objects for an org
f5392c1 
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@netlify
Copy link

netlify bot commented Apr 18, 2022 •
edited
Loading

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit a531ba2
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/625e7d5214bf270009002e2c

@GorillaGigabytes GorillaGigabytes self-assigned this Apr 18, 2022
@GorillaGigabytes GorillaGigabytes added automate-infra-proxy-api using for automate infra proxy backend api's Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues infra-user-mgnt labels Apr 18, 2022
PR Comment
a531ba2 
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vinay033 vinay033 merged commit 7910e16 into feature/infra_user_management Apr 19, 2022
@vinay033 vinay033 deleted the dave/STALWART-100 branch April 19, 2022 10:30
vinay033 pushed a commit that referenced this pull request Apr 19, 2022
@GorillaGigabytes @vinay033
Editor users are able to delete objects for an org (#6924)
dc2dbd0 
* Editor users are able to delete objects for an org

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PR Comment

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
vinay033 pushed a commit that referenced this pull request Apr 22, 2022
@GorillaGigabytes @vinay033
Editor users are able to delete objects for an org (#6924)
ba1e3eb 
* Editor users are able to delete objects for an org

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PR Comment

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
kalroy pushed a commit that referenced this pull request Apr 28, 2022
@GorillaGigabytes @kalroy
Editor users are able to delete objects for an org (#6924)
6563317 
* Editor users are able to delete objects for an org

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PR Comment

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
vinay033 pushed a commit that referenced this pull request May 2, 2022
@GorillaGigabytes @vinay033
Editor users are able to delete objects for an org (#6924)
6a4a87d 
* Editor users are able to delete objects for an org

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PR Comment

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
vinay033 pushed a commit that referenced this pull request May 4, 2022
@GorillaGigabytes @vinay033
Editor users are able to delete objects for an org (#6924)
9457b09 
* Editor users are able to delete objects for an org

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PR Comment

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
vinay033 pushed a commit that referenced this pull request May 9, 2022
@GorillaGigabytes @vinay033
Editor users are able to delete objects for an org (#6924)
1529adc 
* Editor users are able to delete objects for an org

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PR Comment

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
vinay033 pushed a commit that referenced this pull request May 12, 2022
@GorillaGigabytes @vinay033
Editor users are able to delete objects for an org (#6924)
a297e02 
* Editor users are able to delete objects for an org

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PR Comment

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
vinay033 pushed a commit that referenced this pull request May 16, 2022
@GorillaGigabytes @vinay033
Editor users are able to delete objects for an org (#6924)
69487a9 
* Editor users are able to delete objects for an org

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PR Comment

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay033 vinay033 vinay033 approved these changes

@chaitali-mane chaitali-mane chaitali-mane approved these changes

@kalroy kalroy Awaiting requested review from kalroy

Assignees

@GorillaGigabytes GorillaGigabytes

Labels
automate-infra-proxy-api using for automate infra proxy backend api's infra-user-mgnt Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GorillaGigabytes @vinay033 @chaitali-mane