-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplift oc-id to use ruby 3.0.1 and rails 7.0.4 #3674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-server processing.
|
5 tasks
RoyShravani
changed the title
[⚠️ DO NOT MERGE :WIP] Uplift oc-id to use ruby 3.1.0 and rails 7.0.4
[⚠️ DO NOT MERGE :WIP] Uplift oc-id to use ruby 3.0.1 and rails 7.0.4
Jun 23, 2023
RoyShravani
force-pushed
the
roy/oc_id_ruby_upgrade
branch
2 times, most recently
from
June 26, 2023 04:07
621faf2
to
16dfed7
Compare
RoyShravani
changed the title
[⚠️ DO NOT MERGE :WIP] Uplift oc-id to use ruby 3.0.1 and rails 7.0.4
Uplift oc-id to use ruby 3.0.1 and rails 7.0.4
Sep 20, 2023
RoyShravani
requested review from
marcparadise,
kalroy and
sreepuramsudheer
September 20, 2023 06:14
RoyShravani
force-pushed
the
roy/oc_id_ruby_upgrade
branch
from
September 20, 2023 07:41
9f29911
to
b3f6db1
Compare
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com> updating brakeman-analysis Signed-off-by: progress <shravani.roy@progress.com> adding libv8 dependency to lock file Signed-off-by: progress <shravani.roy@progress.com> nit Signed-off-by: progress <shravani.roy@progress.com> ruby update for habitat package Signed-off-by: progress <shravani.roy@progress.com> core/ruby30 Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
RoyShravani
force-pushed
the
roy/oc_id_ruby_upgrade
branch
from
September 26, 2023 09:28
b3f6db1
to
dc5d90a
Compare
saghoshprogress
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Signed-off-by: progress <shravani.roy@progress.com>
RoyShravani
force-pushed
the
roy/oc_id_ruby_upgrade
branch
from
September 26, 2023 19:04
dc5d90a
to
d408d40
Compare
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
Signed-off-by: progress <shravani.roy@progress.com>
RoyShravani
force-pushed
the
roy/oc_id_ruby_upgrade
branch
from
September 27, 2023 05:58
47af61a
to
d7b6690
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
kalroy
approved these changes
Sep 29, 2023
kalroy
added
the
Expeditor: Bump Version Minor
Used by github.minor_bump_labels to bump the Minor version number.
label
Sep 29, 2023
sreepuramsudheer
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Expeditor: Bump Version Minor
Used by github.minor_bump_labels to bump the Minor version number.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
oc-id
(Chef Identity) is running on ruby 2.7 and rails 6. This PR aims to upgrade the application to use ruby 3+ and rails 7+ for better support and maintainability.Issues Resolved
As part of the upgrade, it was found that one of the main gem Doorkeeper has two high security vulnerability issues:
Consequentially, doorkeeper gem has been upgraded from version 4.3 to use 5+. As a part of the doorkeeper upgrade, there has been few updates in the authorization of applications such as Supermarket with
oc-id
or Chef-Identity.The same change that would entail this upgrade has been outlined here: Supermarket authorization with Chef Identity
Demo
Check List
https://chefio.atlassian.net/browse/CHEF-5290