Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable metadata to be got and set #32

Merged
merged 1 commit into from
Feb 28, 2018
Merged

enable metadata to be got and set #32

merged 1 commit into from
Feb 28, 2018

Conversation

thommay
Copy link
Contributor

@thommay thommay commented Feb 28, 2018

Signed-off-by: Thom May thom@chef.io

@thommay thommay requested a review from a team February 28, 2018 14:28
enable metadata to be got and set
6146ee2 
Signed-off-by: Thom May <thom@chef.io>
@robbkidd
Copy link

The changes make sense. Is the reset! behavior worthy of some direct specs?

@robbkidd
Copy link

I'm 99% sure that it's only used in tests.

Fair enough.

@thommay
Copy link
Contributor Author

thommay commented Feb 28, 2018

I'm 99% sure that it's only used in tests.

That comment was so inaccurate i've deleted it. But I'm not sure that there's value in testing it.

robbkidd
robbkidd approved these changes Feb 28, 2018
View reviewed changes
Copy link

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset, it's good for test setup

@thommay thommay merged commit b802425 into master Feb 28, 2018
@robbkidd robbkidd deleted the tm/set_md branch February 28, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbkidd robbkidd robbkidd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thommay @robbkidd