Replace __FILE__ with __dir__ and other minor chefstyle fixes #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few new chefstyle rules to improve readability here. Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
Sep 9, 2020
phiggins
reviewed
Sep 9, 2020
spec/spec_helper.rb
Outdated
| @@ -18,7 +18,7 @@ | |||
| # | |||
|
|
|||
| $TESTING = true | |||
| $:.push File.join(File.dirname(__FILE__), "..", "lib") | |||
| $:.push File.join(__dir__, "..", "lib") | |||
There was a problem hiding this comment.
lib/ is automatically added to the load path in rspec so this is likely unnecessary.
There was a problem hiding this comment.
@phiggins can you make that a suggestion?
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
phiggins
reviewed
Sep 9, 2020
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
phiggins
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few new chefstyle rules to improve readability here.
Signed-off-by: Tim Smith tsmith@chef.io