Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate highlightr custom menu item to Obsidian menu item #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andorx
Copy link

@andorx andorx commented Jul 15, 2022

Related issues #41 #42

I'm not familiar with Obsidian plugins development, but maybe Obsidian doesn't accept custom elements inside menu container anymore, debugging with DevTools showed me nothing than placeholder menu item (with display: none style). So I moved to use Obsidian menu item with defined custom icons.

@RasT110e5
Copy link

Thanks for this, this type of menu allows for selection with keyboard only. I built it locally and replaced it, it works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants