Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sass styles #358

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ArlyMathiasen
Copy link

@faceleg

I've refactored the existing css as SCSS, and added sass, post css for auto-prefixing, and linting tasks for these changes in the dev dependencies and build task.

This gives access to nice things like nested syntax, variables, functions, mixins etc. This makes it easier to maintain and allows users to customize the scss variables of the package.

This contains the same dev dependency updates as #357

please review

updated all dev dependencies to current
added jasmine-core to satisfy peer dependencies
updated syntax in unit tests due to breaking changes in jasmine 2.x syntax
added grunt-sass to dev dependancies
css refactored as sass
sass task added to gruntfile and included as part of default
sass linter added to dev dependancies and to default task
postCSS added to add vendor prefixes to css
removed old css file
pointed the example to the build folder's compiled css where it was referencing the old src css file
@mattbrunetti
Copy link

Tried it out and it looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants