Updates to holography fringestop processing #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareda26
previously approved these changes
Mar 3, 2022
tristpinsm
force-pushed
the
tpm/holo_proc
branch
from
868e493
to
82bd8d4
Compare
* Process one observation at a time instead of grouping them. * Also updated some outdated directory paths and improved logging config.
Add option to raise an exception if no transits were found in the provided data containers (or no data was provided).
Add option to check that gating state associated with dataset ID matches the holography source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed how the fringestop processing groups transits to make it easier to process observations as we go. Let me know you think processing a single observation at a time makes sense. I also added support for gated holography.