Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(docs): move to github-pages #10

Merged
merged 1 commit into from
Feb 17, 2021
Merged

ci(docs): move to github-pages #10

merged 1 commit into from
Feb 17, 2021

Conversation

nritsche
Copy link
Contributor

@nritsche nritsche commented Feb 10, 2021 •
edited
Loading

@nritsche nritsche force-pushed the rn/docs branch 3 times, most recently from 439c638 to 4047073 Compare February 10, 2021 01:27
@nritsche nritsche marked this pull request as ready for review February 10, 2021 01:27
@nritsche nritsche force-pushed the rn/docs branch 2 times, most recently from 1e34c4b to c5fcaa7 Compare February 10, 2021 01:30
@jrs65
Copy link
Contributor

jrs65 commented Feb 10, 2021

The version at that link is ancient. I guess it won't get updated until this is merged?

@nritsche
Copy link
Contributor Author

The version at that link is ancient. I guess it won't get updated until this is merged?

It's actually generated by this PR. What's missing?

@jrs65
Copy link
Contributor

jrs65 commented Feb 10, 2021

I guess I was basing that mostly on the listed version which is 0+untagged.1.g439c638

@jrs65
Copy link
Contributor

jrs65 commented Feb 10, 2021

Hmmm.... that seems to be because the tags weren't repointed when the history was rewritten. Maybe that's why the old history and password could still be found.

@nritsche
Copy link
Contributor Author

Hmmm.... that seems to be because the tags weren't repointed when the history was rewritten. Maybe that's why the old history and password could still be found.

I updated the tags. The docs still show that untagged version string, but github pages might just be slow to update...

@nritsche
Copy link
Contributor Author

the github action for checkout needed to be forced to fetch tags. It works now. @jrs65

@nritsche nritsche merged commit 6382660 into master Feb 17, 2021
@nritsche nritsche deleted the rn/docs branch February 17, 2021 00:58
@anjakefala anjakefala mentioned this pull request Aug 31, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrs65 jrs65 jrs65 approved these changes

@anjakefala anjakefala Awaiting requested review from anjakefala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nritsche @jrs65