Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timing): compatability with corrections generated in real-time #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ssiegelx
Copy link
Contributor

  • The TimingCorrection.from_acq_h5 method will now automatically
    recognize the chime_delay acquisition files that are generated
    by the real-time pipeline, and use a specialized method for
    generating a valid timing correction from these files.

  • Add a predict_x_error method to the TimingCorrection class,
    which will predict the offset in the telescope x position of sources
    due to the measured timing variations.

- The TimingCorrection.from_acq_h5 method will now automatically
recognize the chime_delay acquisition files that are generated
by the real-time pipeline, and use a specialized method for
generating a valid timing correction from these files.

- Add a predict_x_error method to the TimingCorrection class,
which will predict the offset in the telescope x position of sources
due to the measured timing variations.
@ssiegelx
Copy link
Contributor Author

@danielemichilli This PR should enable you to load timing correction files generated by both the offline and real-time pipeline.

It also adds a predict_x_error method to the TimingCorrection class that you should use instead of the version in the baseband-analysis.localization module. It is called as:

dx = tcorr.predict_x_error(timestamp, input_map=input_map)

where input_map is the output of ch_util.tools.get_correlator_inputs. Note that if you do not provide the input_map argument, then the code will query the layout database for this information. This query is the slowest part of the routine, so if you are calling it many times you may want to pass it as an argument.

to fix error when building docs with sphinx.
@danielemichilli
Copy link

@ssiegelx I was finally able to test this, sorry about the huge delay.

The new function formally works but the correction I get is different from the previous version.
For example, I am testing TOA = 1553730069.4198346138, are you able to doublecheck the correct value I should be getting for that timestamp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants