Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added remove_queue command from Resque #237

Merged
merged 2 commits into from
May 13, 2015

Conversation

drahmel
Copy link
Contributor

@drahmel drahmel commented Mar 13, 2015

Resque has the remove_queue command that removes the queue and all of the jobs. Added the method as removeQueue($queue) to php-resque.

@danhunsaker
Copy link
Contributor

You'll probably want to clean out the whitespace changes.

@drahmel
Copy link
Contributor Author

drahmel commented Mar 13, 2015

Done.

@danhunsaker
Copy link
Contributor

Looks good from here.

There's a lot that Ruby's Resque has gained since this port was written that hasn't been ported across yet. Good to see some of it trickling over.

@drahmel
Copy link
Contributor Author

drahmel commented Mar 13, 2015

I noticed that the peek() command was also missing (something I use a lot on Beanstalk) but it is listed on the Resque cheatsheet (http://whatcodecraves.com/posts/2010/06/22/resque-cheatsheet.html). I want to find some time next week to take a shot at implementing that.

@danhunsaker
Copy link
Contributor

Won't get any argument from me. I'd love to see 100% parity between features and in-Redis content in this and the Ruby version. If we can get the latest versions of each to interoperate with each other, that feels like a win. (This version interoperates with an older Ruby version just fine, so we just need to update for the changes since.)

@drahmel
Copy link
Contributor Author

drahmel commented Mar 30, 2015

Any progress on this?

@danhunsaker
Copy link
Contributor

@chrisboulton is pretty busy these days with other projects. When he has enough time free to review this, I'm pretty sure it'll be merged.

@drahmel
Copy link
Contributor Author

drahmel commented Mar 30, 2015

Thanks!

@chrisboulton
Copy link
Owner

Hi,

Sorry for the delay - yes, this seems useful. Thanks!

chrisboulton added a commit that referenced this pull request May 13, 2015
Added remove_queue command from Resque
@chrisboulton chrisboulton merged commit df69e89 into chrisboulton:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants