Performance gain from caching of GetProperties #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a performance gain from caching
GetProperties
result.Since the type properties are immutable we can safely save it in a static property for
ReflectionDocumentMapper<T>
.A simple benchmark indicates a performance gain of 5-10x (depends on the number of properties a class have).
Here is the code that you can open in LinqPad and test it!
https://gist.github.com/khalidsalomao/7f3a6c3f6c514f584d6a
@chriseldredge, when I was review
ReflectionDocumentMapper<T>
I noticed that the GetProperties only return instance properties. What do you think of also supporting its parent public properties by passing the flagBindingFlags.FlattenHierarchy
?