Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflow for pyln tests #51

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Add CI workflow for pyln tests #51

merged 3 commits into from
Jan 4, 2024

Conversation

fmhoeger
Copy link
Collaborator

  • Add CI workflow for pyln tests
  • Update package versions used in nix-package build workflow

Includes all changes from #47 and #48

Needs some commit history cleanup before merging.

@fmhoeger fmhoeger self-assigned this Dec 31, 2023
@fmhoeger fmhoeger linked an issue Dec 31, 2023 that may be closed by this pull request
Add CI workflow for pyln tests #50
Closed
@chrisguida chrisguida mentioned this pull request Jan 2, 2024
Closed
@chrisguida chrisguida changed the base branch from feat/add-tests to master January 2, 2024 23:32
chrisguida
chrisguida approved these changes Jan 3, 2024
View reviewed changes
Copy link
Owner

@chrisguida chrisguida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. It needs to be squashed before merging. Github has a button to squash and merge, or you can do it interactively using git rebase -i.

Let me know which option you prefer.

@fmhoeger fmhoeger force-pushed the 50-add-ci-workflow-for-pyln-tests branch from 96506e4 to 79bf7c5 Compare January 4, 2024 20:30
@fmhoeger fmhoeger force-pushed the 50-add-ci-workflow-for-pyln-tests branch from 79bf7c5 to ed80736 Compare January 4, 2024 20:43
chrisguida
chrisguida approved these changes Jan 4, 2024
View reviewed changes
Copy link
Owner

@chrisguida chrisguida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmhoeger fmhoeger merged commit 5b9aa91 into master Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguida chrisguida chrisguida approved these changes

Assignees

@fmhoeger fmhoeger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI workflow for pyln tests
2 participants
@fmhoeger @chrisguida