Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor python testing code #54

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Refactor python testing code #54

merged 3 commits into from
Jan 30, 2024

Conversation

fmhoeger
Copy link
Collaborator

@fmhoeger fmhoeger commented Jan 18, 2024 •
edited
Loading

  • Refactor Python tests and make them flake8 compatible
  • Update pyproject.toml and .pre-commit-config.yaml
    • Add flake8 and isort packages to dev-dependencies
    • Add flake8 to pre-commit hooks
  • Add pre-commit job to GitHub CI workflow

@fmhoeger fmhoeger self-assigned this Jan 18, 2024
@fmhoeger fmhoeger mentioned this pull request Jan 19, 2024
Closed
@fmhoeger fmhoeger force-pushed the refactor-python-testing-code branch 2 times, most recently from 1fab327 to 43aed6c Compare January 20, 2024 06:48
chrisguida
chrisguida requested changes Jan 20, 2024
View reviewed changes
Copy link
Owner

@chrisguida chrisguida left a comment •
edited by fmhoeger
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add instructions for how to run tests and python formatters
  • Remove PEP8 exceptions
  • Move .pre-commit-config.yaml to root directory so we don't need to copy it there

@fmhoeger fmhoeger force-pushed the refactor-python-testing-code branch 2 times, most recently from 9b39bba to 675fd10 Compare January 28, 2024 23:20
@fmhoeger
Update pyproject.toml and .pre-commit-config.yaml
529760b 
Add flake8 to pre-commit hooks
Add pre-commit job to GitHub CI workflow
@fmhoeger
Refactor Python tests and make them flake8 compatible
c905d88 
Use flake8 defaults and remove .flake8 config
@fmhoeger
Update Development section in README
f3a188b
chrisguida
chrisguida approved these changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@chrisguida chrisguida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@chrisguida chrisguida merged commit a10b4e0 into master Jan 30, 2024
3 checks passed
@chrisguida chrisguida mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguida chrisguida chrisguida approved these changes

Assignees

@fmhoeger fmhoeger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmhoeger @chrisguida