Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4 feature branch route setup CW Review #19

Merged
merged 3 commits into from
May 17, 2024
Merged

#4 feature branch route setup CW Review #19

merged 3 commits into from
May 17, 2024

Conversation

christoph3r3w
Copy link
Owner

@christoph3r3w christoph3r3w commented May 17, 2024 •
edited
Loading

This pull request contains the additions to the server-side code and the client-side posting.

to review

  • check the client-side
  • check if the routes are functional
  • check if the endpoints are logical
  • check if refactoring can take place

@christoph3r3w christoph3r3w added enhancement New feature or request review changes review labels May 17, 2024
@christoph3r3w christoph3r3w requested review from krijnhoetmer and removed request for Jesse-Kramer May 17, 2024 08:44
Jason2426
Jason2426 reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@Jason2426 Jason2426 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything weird in the code and I think it is written correctly. It is also very readable, so that is nice.

@christoph3r3w christoph3r3w merged commit 99f31df into main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jason2426 Jason2426 Jason2426 left review comments

@CharleyMuhren CharleyMuhren Awaiting requested review from CharleyMuhren

@krijnhoetmer krijnhoetmer Awaiting requested review from krijnhoetmer

Assignees

@krijnhoetmer krijnhoetmer

@CharleyMuhren CharleyMuhren

@Jesse-Kramer Jesse-Kramer

@Jason2426 Jason2426

@christoph3r3w christoph3r3w

Labels
enhancement New feature or request review changes review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@christoph3r3w @Jason2426 @krijnhoetmer @CharleyMuhren @Jesse-Kramer