Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 detail pagina layout Chris Desktop layout #36

Merged
merged 4 commits into from
May 24, 2024

Conversation

christoph3r3w
Copy link
Owner

@christoph3r3w christoph3r3w commented May 23, 2024

added

  • media queries
  • updated button navbar
  • general changes
  • intro feature
  • button bar sticky

added
- media queries
- updated btn navbar
- general changes
@christoph3r3w christoph3r3w added enhancement New feature or request review changes review labels May 23, 2024
@christoph3r3w christoph3r3w self-assigned this May 23, 2024
@sannevanseeventer
Copy link
Collaborator

This is already merged, but I still left some comments to improve your code. Down below also some small tips for writing a better pull request.

  • Write a clear title in the comment field.
  • Use headings and categories in your PR: this will make it much more organized.
  • Add images for small and large screens.
  • Add a live link to your PR next time.
  • Next time, you could also include the results of an accessibility test and performance test.
  • Here is a link to an example, you can use this template next time;
    Header Detailpage #64 fdnd-agency/wogo#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review changes review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detail-pagina layout Desktop design voor home & detailpagina
2 participants