CW additions and fixes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added - subgrid to pages - styling for unique grid formats - checks if article is published - general code changes fixes - body alignment issues need to fix - mobile layout bugs - random content inner html
….com/christoph3r3w/pleasurable-ui into 47-adding-subgrid-to-home-page-chris
….com/christoph3r3w/pleasurable-ui into 47-adding-subgrid-to-home-page-chris
fixed - header subgrid alignment - footer subgrid alignment
|
The written CSS looks good I have never worked with subgrids so I can't say if its correct. I also noticed you uncommented a lot of lines of CSS maybe we can remove most of it to prevent confusion and increase readability in our CSS files |
|
I agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
Fixes #46
Added
fixes
need to fix