Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set stable versions of Carto components #35

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

enriquetuya
Copy link

@enriquetuya enriquetuya commented Jun 29, 2018

@chriswhong Thanks for doing the initial efforts for getting everything working in a docker container. We have been looking for something like this for an year or so, so I was really happy when I find your repo.

I had some issues though with the master branch.

1st the first problem was that it did not compile with Windshaft master. Issue #27 and

2nd after getting it running with an older version of Windshaft I started getting the user/admin/api/v2/sql?q=select%20*%20from%20cdb_dataservices_client.cdb_service_quota_info() issue, see #30 (comment)

So I started looking into a way of pinning versions that worked taking the work done by @Prindle19 and @sabman in the ticket: #33

I manage to pin some version from Jan 2018 that work. My suggestion is if you want to merge this PR so everyone getting to your repo and running the build get a working version of Carto.

This PR covers:

  • Modifications in order of the Docker file so it runs faster on version change iteration. Only the last steps got change when you change the version of the components.
  • Change the used volumes. This was done by @andres-arana
    • The postgres volumes that were used are the suggested for a dev environment.
    • The Carto documentation recommend persisting redis, so we also added a volume for that.
    • Used named volumes. Check the Readme, so they are easier to reference.
  • Set versions to early Jan 2018:
cartodb_postgresql_version=0.21.0
cartodb_version=v4.11.59
cartodb_windshaft_version=5.0.0
cartodb_sql_api_version=1.48.1

We should work into having more up to date version of the components and also try to move from ubuntu 12 to ubuntu 16, that's the recomended version in the Carto documentation.

This PR:
Closes #27
Closes #33
Closes #30
Closes #28
Closes #31

Relates #32
Relates #23 in some way.

@thadk
Copy link

thadk commented Aug 7, 2018

Why did you take this portion out of the README?
If you are replacing an existing container built with this image, add t...

It helped me in the past.

@enriquetuya
Copy link
Author

@thadk check the now the volumes are created before hand in the readme so you end up having two named volumes that will be used by the container. This gives you couple of benfits:

  • You always know which are the volumes the container will be using, giving you the ability to add a backup process, mount them on an specific dir, etc.
  • You will always run the same command to start the container, no need to check for the volumes id if you need to build a new version or migrate or any other reason. The command will always be: sudo docker run -d -v cartodb-postgres:/var/lib/postgresql -v cartodb-redis:/var/lib/redis -p 3000:3000 -p 8080:8080 -p 8181:8181 cartodb

@chriswhong
Copy link
Owner

Hey all, I am not able to maintain this anymore... Does someone want to be added as a collaborator who can review PRs and keep it going?

@sabman
Copy link
Collaborator

sabman commented Aug 10, 2018

If no one else has time I'm happy to volunteer. I'd also like to start a Roadmap so we can have longer term support. Starting with some automated builds and tests.

@chriswhong
Copy link
Owner

@sabman I'll add you as a contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants