Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test missing for error condition internal.domain.name.cannot_compute_etld1 #81

Closed
april opened this issue Jun 23, 2016 · 3 comments
Closed

Test missing for error condition internal.domain.name.cannot_compute_etld1 #81

april opened this issue Jun 23, 2016 · 3 comments
Labels
domain.go [Type] enhancement

Comments

@april
Copy link

april commented Jun 23, 2016 •
edited
Loading

Error code internal.domain.name.cannot_compute_etld1 lacks any kind of test. blogspot.com is an example domain where this error pops up on.
@lgarron
Copy link
Collaborator

lgarron commented Jun 23, 2016

Good idea.

@lgarron
Copy link
Collaborator

lgarron commented Jun 23, 2016

I was thinking of having a special message if the domain that is entered is an eTLD, because we want to encourage preloading those if at all possible.

@april
Copy link
Author

april commented Jun 23, 2016

Seems good to me!

@lgarron lgarron mentioned this issue Jun 27, 2016
Closed
lgarron added a commit that referenced this issue Jun 27, 2016
@lgarron
Add a test for internal.domain.name.cannot_compute_etld1. Closes #81.
afcd43a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain.go [Type] enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@april @lgarron