Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise default include/exclude patterns for Chromium enlistements #70

Open
rpaquay opened this issue Jun 23, 2020 · 4 comments
Open

Revise default include/exclude patterns for Chromium enlistements #70

rpaquay opened this issue Jun 23, 2020 · 4 comments
Assignees

Comments

@rpaquay
Copy link
Contributor

rpaquay commented Jun 23, 2020

The list of default files to include/exclude for Chromium enlistments was written years ago and has not been updated since then. For example, the search pattern exclude "*.s" files (assembly source files). There is not reason to do that anymore.

The default files are located here:

https://github.com/chromium/vs-chromium/tree/master/src/Server/Configuration

They can be overridden using custom configuration files, but the list should be simplified for more general usage.

@rpaquay rpaquay self-assigned this Jun 23, 2020
@rpaquay
Copy link
Contributor Author

rpaquay commented Jun 23, 2020

@randomascii fyi

@randomascii
Copy link

It could also be helpful to have an action that takes the defaults and creates a vs-chromium-project.txt file for editing. Right now switching from the defaults to a configuration file is a big change with unclear consequences.

rpaquay added a commit that referenced this issue Jun 25, 2020
Remove all exclusion rules for files that can contain text, leaving
only exclusion rules for file extensions that are known to be binary
files (e.g. .obj, .pdb, .exe, etc.)

This increase the number of files scanned and indexed by default,
but makes the rules more general purpose and avoid confusions related
to seemingly incomplete search results.

This fixes issue #70
@rpaquay
Copy link
Contributor Author

rpaquay commented Jun 26, 2020

Note:
This was implemented in c062ad5

Before;

  • Number of files: 325,973
  • Number of searchable files: 252,425
  • Memory usage: 2,386 MB

After;

  • Number of files: 478,024
  • Number of searchable files: 397,088
  • Memory usage: 3,594 MB

That is quite an increase in memory usage (~50%). Most of the increase come from files with these extensions:

  • .json
  • .txt
  • .ninja
  • .dic
  • .xtb
  • .test

@rpaquay
Copy link
Contributor Author

rpaquay commented Jun 26, 2020

Fixed in v0.9.37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants