Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared client: Fix global timeout not being respected #11

Merged
merged 1 commit into from
Apr 16, 2024

Commits on Apr 16, 2024

  1. shared client: Fix global timeout not being respected

    This fixes a bug where the shared client did not respect
    `c.Client.Timeout`, resulting in DNS requests timing out too soon.
    
    A per Go docs, `Client.Timeout` is supposed to also apply to the write
    timeout. This is implemented in the regular client by using
    `Client.getTimeoutForRequest` to determine the actual timeout. This
    commit adapts the shared client code to do the same.
    
    Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
    gandro committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ee3124a View commit details
    Browse the repository at this point in the history