Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying Implementation Steps of Chat 5.1 #450

Conversation

mdueltgen
Copy link
Collaborator

@mdueltgen mdueltgen commented Oct 2, 2024

🗣 Description

Updated 5.1 steps for editing rules for clarity.

💭 Motivation and context

Closes #448
Based on Internal Discussion about clarifying steps for rule configuration polices

🧪 Testing

N/A no code changes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

Copy link
Collaborator

@buidav buidav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deja vu. Didn't realize we had 2 policy groups for DLP.
One for Google Chat and one for Google Drive.
Maybe DLP Rules should be moved to Common Controls since they apply across multiple apps?

Seems like DLP Rules recently expanded to Gmail as well.
MultipleServices

@adhilto adhilto force-pushed the 448-take2-chat-51-clarify-that-implementation-steps-need-to-be-repeated-for-each-rule branch from 36aac81 to 4661c72 Compare October 3, 2024 14:25
@mdueltgen
Copy link
Collaborator Author

Since we have decided to move DLP to common controls I will close this PR

@mdueltgen mdueltgen closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants