Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Spell check Crossfeed's pages #102

Merged
merged 5 commits into from
Mar 19, 2024
Merged

UI: Spell check Crossfeed's pages #102

merged 5 commits into from
Mar 19, 2024

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Mar 19, 2024 •
edited
Loading

🗣 Description

Look over UI and fix any spelling/grammatical errors.
#96

💭 Motivation and context

Improves user experience.

🧪 Testing

Spelling typo "severity" is fixed.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav self-assigned this Mar 19, 2024
@ameliav ameliav marked this pull request as ready for review March 19, 2024 17:44
@ameliav ameliav linked an issue Mar 19, 2024 that may be closed by this pull request
UI: Spell Check Crossfeed's pages #96
Closed
schmelz21
schmelz21 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schmelz21 schmelz21 merged commit bd46d12 into develop Mar 19, 2024
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmelz21 schmelz21 schmelz21 approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

Assignees

@ameliav ameliav

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Spell Check Crossfeed's pages
2 participants
@ameliav @schmelz21