Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall ip Node Module (Backend) #403

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Uninstall ip Node Module (Backend) #403

merged 1 commit into from
Jul 10, 2024

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Jul 5, 2024 •
edited
Loading

🗣 Description

💭 Motivation and context

ip is a vulnerable node module that we don't use.
See GHSA-2p57-rm9w-gvfp
Closes issue #402

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson linked an issue Jul 5, 2024 that may be closed by this pull request
Vulnerability: Backend - ip #402
Closed
@Matthew-Grayson Matthew-Grayson self-assigned this Jul 5, 2024
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review July 5, 2024 13:54
@Matthew-Grayson Matthew-Grayson changed the title Uninstall ip node module. Uninstall ip Node Module (Backend) Jul 8, 2024
@Matthew-Grayson Matthew-Grayson mentioned this pull request Jul 8, 2024
Closed
aloftus23
aloftus23 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. confirmed not being used

@schmelz21 schmelz21 merged commit 006fd46 into develop Jul 10, 2024
16 of 18 checks passed
@schmelz21 schmelz21 deleted the 402-vulnerability-backend-ip branch July 10, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloftus23 aloftus23 aloftus23 approved these changes

@schmelz21 schmelz21 schmelz21 approved these changes

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

Assignees

@Matthew-Grayson Matthew-Grayson

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability: Backend - ip
3 participants
@Matthew-Grayson @aloftus23 @schmelz21