Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove n/a hooks from pre-commit: nix, golang, toml, and xml. #45

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Mar 12, 2024

🗣 Description

Remove the following pre-commit hooks:

  • check-toml
  • check-xml
  • go-critic
  • go-staticcheck-repo-mod
  • go-build-repo-mod
  • go-mod-tidy-repo
  • go-test-repo-mod
  • go-vet-repo-mod
  • go-sec-repo-mod
  • nixpkgs-fmt

💭 Motivation and context

Closes issue #44
These hooks check languages or file types that are not in XFD.
XFD has no golang, nix, or *.toml files.
XFD has *.xml files in matomo-data, however these are generated/not version-controlled.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson linked an issue Mar 12, 2024 that may be closed by this pull request
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review March 12, 2024 16:37
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed these are out of scope. And is understood this is an incremental update to linting issues.

Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cduhn17 cduhn17 merged commit 2197a69 into develop Mar 12, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prune Non-Applicable pre-commit Hooks
3 participants