Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unused Lambda cloudwatchToS3 #508

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Remove Unused Lambda cloudwatchToS3 #508

wants to merge 2 commits into from

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Jul 31, 2024 •
edited
Loading

🗣 Description

Remove cloudwatchToS3 and associated dependencies:
@aws-sdk/client-ssm
@aws-sdk/client-cloudwatch-logs

💭 Motivation and context

Reduces package size and build time.
Closes issue #289

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson
Remove cloudwatchToS3 Lambda
d1d246f 
Delete cloudwatchToS3.ts
Remove cloudwatchToS3 from functions.yml
Remove @aws-sdk/client-ssm and @aws-sdk/client-cloudwatch-logs from backend package files
@Matthew-Grayson
Remove cloudwatchToS3 Lambda
9f7c0f8 
Delete cloudwatchToS3.ts
Remove cloudwatchToS3 from functions.yml
Remove @aws-sdk/client-ssm and @aws-sdk/client-cloudwatch-logs from backend package files
@Matthew-Grayson Matthew-Grayson linked an issue Jul 31, 2024 that may be closed by this pull request
Remove Unused Lambda cloudwatchToS3 #289
Open
@Matthew-Grayson Matthew-Grayson changed the title 289 remove unused lambda cloudwatchtos3 Remove Unused Lambda cloudwatchToS3 Jul 31, 2024
@Matthew-Grayson Matthew-Grayson self-assigned this Jul 31, 2024
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review July 31, 2024 13:17
@schmelz21
Copy link
Collaborator

@aloftus23 or @cduhn17 - just need one more to confirm to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmelz21 schmelz21 schmelz21 approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

Assignees

@Matthew-Grayson Matthew-Grayson

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Unused Lambda cloudwatchToS3
2 participants
@Matthew-Grayson @schmelz21