Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excludes dhs region organization selections #624

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Excludes dhs region organization selections #624

merged 6 commits into from
Sep 18, 2024

Conversation

jayjaybunce
Copy link
Collaborator

🗣 Description

  • Filters any dhs region organizations out of the organization search and selection as well as from the initial filters we populate on page load.
  • This provides a better first view for these users as they will be presented with their region 3 data rather than an empty dashboard

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me. I assigned myself to an organization called DHS Region 3 and I couldn't find it in the organization search.

image

Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How important is the "c" missing in exclude in refinedOrgs at Line 102?

Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replicated what Amelia did:

  • Added an org named dhs region 3 and it does not show up.
  • Commented out the new exclusion and it does show up.

LGTM.

@ameliav ameliav self-requested a review September 17, 2024 20:57
Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I found an issue.

The domains and vulnerabilities table is now showing no entries if your default org is "DHS Region x"

image
image

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@schmelz21 schmelz21 merged commit 0ebf591 into develop Sep 18, 2024
19 of 22 checks passed
@schmelz21 schmelz21 deleted the crasm-620 branch September 18, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants