Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance flagFloatingIps #667

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Enhance flagFloatingIps #667

merged 4 commits into from
Oct 3, 2024
+81 −55

Conversation

DJensen94
Copy link
Contributor

@DJensen94 DJensen94 commented Oct 3, 2024 •
edited by aloftus23
Loading

Enhance flagFloatingIps

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@DJensen94
Enhance flagFloatingIps
36a6cc5 
Enhance flagFloatingIps
@DJensen94
adjust frontend error handling
3707c93 
adjust frontend error handling
@DJensen94
adjust front end again
38fa3ce 
adjust front end again
@DJensen94
Run precommit
f9da755 
Run precommit
@aloftus23 aloftus23 marked this pull request as ready for review October 3, 2024 20:04
aloftus23
aloftus23 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@schmelz21 schmelz21 merged commit 761d16b into develop Oct 3, 2024
17 of 20 checks passed
@schmelz21 schmelz21 deleted the dj_hotfix3_WIP branch October 3, 2024 20:12
aloftus23 pushed a commit that referenced this pull request Oct 3, 2024
@DJensen94 @aloftus23
Enhance flagFloatingIps (#667)
41c23a4 
* Enhance flagFloatingIps

Enhance flagFloatingIps

* adjust frontend error handling

adjust frontend error handling

* adjust front end again

adjust front end again

* Run precommit

Run precommit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloftus23 aloftus23 aloftus23 approved these changes

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DJensen94 @aloftus23 @schmelz21